Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip future shipped apps from updatenotification check #48375

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Skip future shipped apps from updatenotification check #48375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aea325f
fix(updatenotification): Communicate files_downloadlimit as shipped i…
nickvergessen Sep 26, 2024
7c683a9
fix(updatenotification): Communicate twofactor_nextcloud_notification…
nickvergessen Sep 26, 2024
727fe27
fix(updatenotification): Communicate app_api as shipped in 30+
nickvergessen Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/updatenotification/lib/Controller/APIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class APIController extends OCSController {
'bruteforcesettings' => 25,
'suspicious_login' => 25,
'twofactor_totp' => 25,
'files_downloadlimit' => 29,
'twofactor_nextcloud_notification' => 30,
'app_api' => 30,
Comment on lines 39 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'bruteforcesettings' => 25,
'suspicious_login' => 25,
'twofactor_totp' => 25,
'files_downloadlimit' => 29,
'twofactor_nextcloud_notification' => 30,
'app_api' => 30,
'app_api' => 30,
'bruteforcesettings' => 25,
'circles' => 22,
'files_downloadlimit' => 29,
'suspicious_login' => 25,
'twofactor_nextcloud_notification' => 30,
'twofactor_totp' => 25,

+circles? (though I guess it may not matter at this point)
sort maybe too since we're here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't help to add things from the past which we don't release anymore.
Also it's sorted by version added atm, just got mixed as app_api is not 31 bug 30 and I amended the fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its easier to compare with the packaging script this way 🙈

];

public function __construct(
Expand Down
Loading