-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable29] ci: fail psalm when baseline update required #48471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
miaulalala,
provokateurin and
kesselb
September 30, 2024 17:06
provokateurin
approved these changes
Sep 30, 2024
Meh now we have some diff because of the CDATA stuff which is somehow inconsistent 😢 |
kesselb
force-pushed
the
backport/48466/stable29
branch
from
September 30, 2024 21:28
f26b318
to
7286b35
Compare
Yep, we need psalm ~5.22 to have a stable psalm baseline: vimeo/psalm#10632 |
miaulalala
approved these changes
Oct 1, 2024
Merged
Conflict with psalm baseline |
kesselb
force-pushed
the
backport/48466/stable29
branch
from
October 30, 2024 14:34
3379869
to
2828dd8
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
To ensure we have a stable baseline Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
backport/48466/stable29
branch
from
October 30, 2024 14:36
2828dd8
to
c9b0742
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
backport/48466/stable29
branch
from
October 30, 2024 14:54
c9b0742
to
8469e1a
Compare
Conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #48466