fix(caldav): duration handling in the event reader class #48723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added
bug
3. to review
st3iny
requested review from
miaulalala and
SebastianKrupinski
as code owners
|
/backport to stable30 |
SebastianKrupinski
approved these changes
Oct 21, 2024
|
/backport to stable30 |
provokateurin
approved these changes
Nov 4, 2024
ChristophWurst
approved these changes
Nov 4, 2024
ChristophWurst
added
4. to release
hamza221
approved these changes
Nov 4, 2024
miaulalala
approved these changes
Nov 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The call to
$this->baseEvent->DURATION->getDateInterval()returns an instance ofDateIntervalbut$this->baseEventDurationis an int.Checklist