Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files_sharing): Add proper user facing messages on success #48729

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 16, 2024

Backport of #48696

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Ivansss, Pytal and susnux October 16, 2024 10:50
@backportbot backportbot bot added this to the Nextcloud 29.0.9 milestone Oct 16, 2024
@susnux susnux force-pushed the backport/48696/stable29 branch from e13d97f to e127bbb Compare October 17, 2024 16:11
@susnux susnux marked this pull request as ready for review October 17, 2024 16:11
1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/48696/stable29 branch from e127bbb to e72672a Compare October 21, 2024 10:22
@susnux
Copy link
Contributor

susnux commented Oct 21, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux enabled auto-merge October 21, 2024 11:35
@susnux susnux merged commit ed17447 into stable29 Oct 21, 2024
110 checks passed
@susnux susnux deleted the backport/48696/stable29 branch October 21, 2024 11:45
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants