Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appstore): Hide last modified information for shipped apps #48743

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Oct 16, 2024

Summary

Don't show the last modified information for apps that are shipped.

Before:
Bildschirmfoto 2024-10-16 um 23 43 41

After:
Bildschirmfoto 2024-10-16 um 23 45 36

Checklist

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper added the 3. to review Waiting for reviews label Oct 16, 2024
@SystemKeeper SystemKeeper added this to the Nextcloud 31 milestone Oct 16, 2024
@SystemKeeper SystemKeeper requested review from joshtrichards, susnux and a team October 16, 2024 21:52
@SystemKeeper SystemKeeper self-assigned this Oct 16, 2024
@SystemKeeper SystemKeeper requested review from skjnldsv and sorbaugh and removed request for a team October 16, 2024 21:52
@provokateurin provokateurin merged commit 4100f58 into master Oct 17, 2024
177 checks passed
@provokateurin provokateurin deleted the fix/45717/hide-last-modified-for-shipped-apps branch October 17, 2024 06:59
@provokateurin
Copy link
Member

/backport to stable30

@provokateurin
Copy link
Member

/backport to stable29

@provokateurin
Copy link
Member

/backport to stable28

Copy link

backportbot bot commented Oct 17, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/48743/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 74d179ed

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48743/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@SystemKeeper
Copy link
Contributor Author

In 28 we don't show the last modified information it seems -> skipping the backport.

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
3 participants