Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix(files): handle empty view with error #48934

Merged
merged 4 commits into from
Oct 29, 2024
Merged

[stable29] fix(files): handle empty view with error #48934

merged 4 commits into from
Oct 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 28, 2024

Empty Error
image image

@ShGKme ShGKme added this to the Nextcloud 29.0.9 milestone Oct 28, 2024
@ShGKme ShGKme requested a review from susnux October 28, 2024 11:23
@ShGKme ShGKme self-assigned this Oct 28, 2024
@ShGKme ShGKme requested a review from skjnldsv as a code owner October 28, 2024 11:23
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 28, 2024

/backport to stable28

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 28, 2024

/backport! to stable28

@backportbot backportbot bot mentioned this pull request Oct 28, 2024
Merged
2 tasks
ShGKme added 4 commits October 28, 2024 21:12
@ShGKme
chore(files): migrate davUtils to TS
65bf473 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(files): handle empty view with error
d9d7d64 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(files): migrate to @nextcloud/sharing
d453426 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(assets): Recompile assets
cdb6b42 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/48625/stable29 branch from 9fdca7c to cdb6b42 Compare October 28, 2024 20:15
@skjnldsv skjnldsv merged commit 271d5de into stable29 Oct 29, 2024
110 checks passed
@skjnldsv skjnldsv deleted the backport/48625/stable29 branch October 29, 2024 06:44
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024
skjnldsv
skjnldsv reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@backportbot backportbot bot mentioned this pull request Oct 29, 2024
Closed
2 tasks
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv left review comments

@susnux susnux Awaiting requested review from susnux

Assignees

@ShGKme ShGKme

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 29.0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @skjnldsv