fix(db): Stop writing unused dbport
to config at install time
#49104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already have handling for specifying a port at install time or later on (which work just fine). Yet we write out a bogus parameter
dbport
to the initial config.This value is neither supported nor used (even at install time). Yet we save this bogus parameter in the initial config. Since it's in the config, people end up assuming it does something and wondering why it doesn't work.
It either ends up being:
Or, if a specific port was explicitly specified via
maintenance:install --database-port
than that port ends up there. It gets populated with the correct value, but it's still not actually used so 🤷Let's not write it to the config at install time since it's a no-op and avoid all this confusion.
Additional historical context:
TODO
Checklist