Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): Stop writing unused dbport to config at install time #49104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Nov 5, 2024

  • Resolves: #

Summary

We already have handling for specifying a port at install time or later on (which work just fine). Yet we write out a bogus parameter dbport to the initial config.

This value is neither supported nor used (even at install time). Yet we save this bogus parameter in the initial config. Since it's in the config, people end up assuming it does something and wondering why it doesn't work.

It either ends up being:

        "dbport": "",

Or, if a specific port was explicitly specified via maintenance:install --database-port than that port ends up there. It gets populated with the correct value, but it's still not actually used so 🤷

        "dbport": "3306",

Let's not write it to the config at install time since it's a no-op and avoid all this confusion.

Additional historical context:

TODO

  • ...

Checklist

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 31 milestone Nov 5, 2024
@skjnldsv skjnldsv requested review from nickvergessen, a team, Altahrim, skjnldsv and sorbaugh and removed request for a team November 6, 2024 07:54
@joshtrichards joshtrichards added the papercut Annoying recurring issue with possibly simple fix. label Dec 30, 2024
@blizzz blizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: database Database related DB feature: install and update papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants