Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files_sharing): use share node or label as page title #49142

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat(files_sharing): use share node or label as page title #49142

merged 1 commit into from
Nov 8, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 8, 2024

Fix #11506

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 8, 2024
@skjnldsv skjnldsv requested review from jancborchardt, susnux and a team November 8, 2024 07:58
@skjnldsv skjnldsv self-assigned this Nov 8, 2024
@skjnldsv skjnldsv requested review from artonge and szaimen and removed request for a team November 8, 2024 07:58
@skjnldsv
feat(files_sharing): use share node or label as page title
4d9d617 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 8, 2024
@skjnldsv skjnldsv merged commit d5caf91 into master Nov 8, 2024
173 of 174 checks passed
@skjnldsv skjnldsv deleted the feat/sharing-title branch November 8, 2024 13:38
jancborchardt
jancborchardt reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv thank you so much for fixing this btw @skjnldsv, it has been bugging me again recently, forgot about the open issue. :D

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@susnux susnux susnux approved these changes

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files feature: sharing
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Titles for share pages are not specific
4 participants
@skjnldsv @jancborchardt @ArtificialOwl @susnux