[stable28] fix(files): Allow downloading multiple nodes not from same base #49203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable29 |
|
/backport to stable30 |
8 tasks
skjnldsv
approved these changes
Nov 11, 2024
nfebe
approved these changes
Nov 18, 2024
When downloading files in e.g. the *favorites* or *recent* view, then the nodes are not always share the same parent folder and we can not use the current directory as it is probably just a virtual one. So we calculate the longest common base and use that as the directory for the download endpoint. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/download-non-files-view
branch
from
62b2485 to
11c847a
Compare
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When downloading files in e.g. the favorites or recent view, then the nodes are not always share the same parent folder and we can not use the current directory as it is probably just a virtual one.
So we calculate the longest common base and use that as the directory for the download endpoint.
Screen recording
Bildschirmaufnahme_20241111_161224.webm
Already fixed for 31.
Checklist