fix(core): Do not use v-html for translation output
#49346
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content that can be renderered does *not* include HTML (see `recommended` object). But `v-html` was used, this is potentially dangerous, even though we sanitize the translation values, so no urgent harm but better safe than sorry. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
nickvergessen,
a team,
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The content that can be rendered does not include HTML (see
recommendedobject).But
v-htmlwas used, this is potentially dangerous, even though we sanitize the translation values, so no urgent harm but better safe than sorry.Checklist