Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shares): Remove noisy text from email #49847

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Dec 13, 2024

Summary

See #49746 (review)

Checklist

@solracsf solracsf added the 2. developing Work in progress label Dec 13, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Dec 13, 2024
@solracsf solracsf force-pushed the removeNoisyTextEmails branch from d639a8c to b828999 Compare December 16, 2024 07:13
@solracsf solracsf marked this pull request as ready for review December 16, 2024 07:13
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 16, 2024
@solracsf
Copy link
Member Author

/backport to stable30

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the removeNoisyTextEmails branch from b828999 to 20215fb Compare December 16, 2024 14:16
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @solracsf, looks nice! :)

@solracsf solracsf merged commit 4b3b09f into master Dec 23, 2024
188 checks passed
@solracsf solracsf deleted the removeNoisyTextEmails branch December 23, 2024 14:21
Copy link

backportbot bot commented Dec 23, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/49847/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 20215fbd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49847/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@solracsf
Copy link
Member Author

/backport to stable30

Copy link

backportbot bot commented Dec 24, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/49847/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 20215fbd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49847/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@joshtrichards
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants