-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't skip scanner users filesystem if they have a mountpoint at /<user>/files/ #49887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
nfebe,
skjnldsv and
provokateurin
and removed request for
a team
December 16, 2024 19:32
icewind1991
force-pushed
the
scan-home-ext-storae
branch
from
December 16, 2024 19:40
c0112fd
to
c8b6398
Compare
provokateurin
approved these changes
Dec 16, 2024
Antreesy
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That covers intended usecase with external storage on '/'
icewind1991
force-pushed
the
scan-home-ext-storae
branch
3 times, most recently
from
December 20, 2024 17:54
313a6ae
to
3f8d6e0
Compare
… /<user>/files/ Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
scan-home-ext-storae
branch
from
December 27, 2024 14:18
3f8d6e0
to
7bc8eb3
Compare
skjnldsv
approved these changes
Dec 28, 2024
/backport to stable30 |
/backport to stable29 |
2 tasks
2 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently gives a false positive for the "skip scanning if user isn't setup.