fix: Create empty file instead of file with a space #49936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <jus@bitgrid.net>
|
/backport to stable29 |
|
/backport to stable28 |
juliusknorr
requested review from
icewind1991,
blizzz,
elzody,
a team,
provokateurin and
sorbaugh
and removed request for
a team
provokateurin
approved these changes
Dec 20, 2024
blizzz
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in c22776f but writing empty files was properly fixed in #14210
It turns out that MS Office Online server requires new files that are opened to be totally empty in some cases.
Ref nextcloud/officeonline#593 which made it work with 1 byte files but this only works for word/excel, not powerpoint.
This PR is against 30 as with 31 this code is no longer in place.