Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): flaky live photo test grid_view trigger issue #50025

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 3, 2025

WIP

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title tmp: record and upload video run fix(cypress): flaky live photo test grid_view trigger issue Jan 3, 2025
@skjnldsv skjnldsv self-assigned this Jan 3, 2025
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews tests Related to tests labels Jan 3, 2025
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Jan 3, 2025
@skjnldsv skjnldsv marked this pull request as ready for review January 3, 2025 09:29
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@skjnldsv skjnldsv enabled auto-merge January 3, 2025 10:03
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 3, 2025
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 3, 2025

/backport bc523f6 to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 3, 2025

/backport bc523f6 to stable29

@skjnldsv skjnldsv merged commit 99147b8 into master Jan 3, 2025
191 checks passed
@skjnldsv skjnldsv deleted the fix/flaky-cypress branch January 3, 2025 10:11
@SystemKeeper
Copy link
Contributor

Just to have this documented somewhere. The original issue comes from a "little" sideeffect of cypress' .type() method:

If the element is currently not in focus, before issuing any keystrokes Cypress will first issue a .click() to the element to bring it into focus.

(https://docs.cypress.io/api/commands/type#When-element-is-not-in-focus)

Since the dialog is not focused, a click is done by cypress in the middle of the dialog, which happens to be the Enable the grid view checkbox on the runners. It seems the runners use a different font than we use locally which brings the element into "the click range".

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 7, 2025

Since the dialog is not focused

Shouldn't it always take the focus on open? 🤔

@SystemKeeper
Copy link
Contributor

Since we click on the checkbox input, that one has the input, not the dialog itself. Probably (didn't test) if we do the type on the input element it would work correctly.

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants