-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cypress): flaky live photo test grid_view trigger issue #50025
Conversation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
e8cb458
to
43b3ad1
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
f86553b
to
bc523f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
/backport bc523f6 to stable30 |
/backport bc523f6 to stable29 |
Just to have this documented somewhere. The original issue comes from a "little" sideeffect of cypress'
(https://docs.cypress.io/api/commands/type#When-element-is-not-in-focus) Since the dialog is not focused, a click is done by cypress in the middle of the dialog, which happens to be the |
Shouldn't it always take the focus on open? 🤔 |
Since we click on the checkbox input, that one has the input, not the dialog itself. Probably (didn't test) if we do the type on the input element it would work correctly. |
WIP