Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] Don't trigger activity when the email didn't change #5186

Merged
merged 1 commit into from
Jun 7, 2017
Merged

[stable12] Don't trigger activity when the email didn't change #5186

merged 1 commit into from
Jun 7, 2017

Conversation

nickvergessen
Copy link
Member

Backport #5126

@nickvergessen
Don't trigger activity when the email didn't change
ea9613e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 12.0.1 milestone May 31, 2017
blizzz
blizzz reviewed Jun 1, 2017
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary with more recent #5216, unless you want an additional safety net

@nickvergessen
Copy link
Member Author

I would keep it, just to be sure and since this was already given out to multiple users as a patch.

@blizzz
Copy link
Member

blizzz commented Jun 1, 2017

makes sense. 👍 then

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 1, 2017
@nickvergessen nickvergessen requested a review from MorrisJobke June 7, 2017 09:04
MorrisJobke
MorrisJobke approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit d08a6c7 into stable12 Jun 7, 2017
@MorrisJobke MorrisJobke deleted the backport-5126-email-change-spam branch June 7, 2017 16:14
@nickvergessen nickvergessen mentioned this pull request Sep 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz left review comments

@icewind1991 icewind1991 icewind1991 approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: activity and notification
Projects
None yet
Milestone
Nextcloud 12.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @blizzz @MorrisJobke @icewind1991