Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if an app provide two-factor-auth providers before we try to use them #534

Merged
merged 1 commit into from
Jul 23, 2016
Merged

Check if an app provide two-factor-auth providers before we try to use them #534

merged 1 commit into from
Jul 23, 2016

Conversation

icewind1991
Copy link
Member

Prevents log spam

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 23, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Jul 23, 2016
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @nickvergessen to be potential reviewers

@ChristophWurst
Copy link
Member

👍 makes sense. I think the error only occurs if $this->appManager->getEnabledAppsForUser($user) returns app IDs of apps that do not exist any more on the file system and therefore the info.xml file can not be loaded.

@nickvergessen
Copy link
Member

https://github.com/nextcloud/server/pull/534/files?w=1

🙈 👍

@nickvergessen nickvergessen merged commit dddd43f into master Jul 23, 2016
@nickvergessen nickvergessen deleted the twofactor-isset branch July 23, 2016 13:49
@nickvergessen
Copy link
Member

Backport to stable10?

@MorrisJobke
Copy link
Member

cc @icewind1991 @ChristophWurst @karlitschek

@karlitschek
Copy link
Member

great. please backport 👍

@icewind1991 icewind1991 mentioned this pull request Aug 6, 2016
Merged
@icewind1991
Copy link
Member Author

Stable 10: #756

@ChristophWurst ChristophWurst mentioned this pull request Aug 9, 2016
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@icewind1991 @mention-bot @ChristophWurst @nickvergessen @MorrisJobke @karlitschek