-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix design details in comments sidebar #714
Conversation
@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @vincchan and @MorrisJobke to be potential reviewers |
@@ -31,8 +32,8 @@ | |||
'{{/if}}' + | |||
' </div>' + | |||
' <form class="newCommentForm">' + | |||
' <textarea class="message" placeholder="{{newMessagePlaceholder}}">{{{message}}}</textarea>' + | |||
' <input class="submit" type="submit" value="{{submitText}}" />' + | |||
' <input type="text" class="message" placeholder="{{newMessagePlaceholder}}" value="{{{message}}}"" />' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double quotes ending
looks really nice and works! :) 👍 |
failing test PhantomJS 2.1.1 (Linux 0.0.0) OCA.Comments.CommentsTabView tests editing comments saves message and updates comment item when clicking save FAILED EDIT: also when we're on the subject editing comments looks a bit weird atm compared to newcomments form |
Looks much nicer, Works |
-.- Oh ... it was already reported. @jancborchardt Please fix this ;) |
Beside that it looks nice :) |
b71f990
to
eab3ae5
Compare
Only because it is an input now so you can now longer format text (newlines). I don't really have an opinion here. But let you all decide. Review time |
eab3ae5
to
0d96478
Compare
* tested in IE10, IE11, Edge, Chrome and Firefox
I tested it and it now works really great 👍 from me |
LGTM! |
This still had open comments... Will fix #714 (comment) |
Fix in #928 |
fix design details in comments sidebar
Currently there’s a textarea for comment posting in the sidebar. I’d say we only use an input field to encourage short and concise comments.
When we use comments in the Activity app etc, we can use textareas, but not in smaller areas like the sidebar.
Then also pressing enter now sends the message, much quicker.
And the layout is improved overall. Focus on the message rather than author and date, which only get half opacity.
Before & after:
Please review @nextcloud/designers :)