Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix design details in comments sidebar #714

Merged
merged 5 commits into from
Aug 18, 2016
Merged

Conversation

jancborchardt
Copy link
Member

Currently there’s a textarea for comment posting in the sidebar. I’d say we only use an input field to encourage short and concise comments.
When we use comments in the Activity app etc, we can use textareas, but not in smaller areas like the sidebar.
Then also pressing enter now sends the message, much quicker.

And the layout is improved overall. Focus on the message rather than author and date, which only get half opacity.

Before & after:
capture du 2016-08-03 13-25-17
Please review @nextcloud/designers :)

@mention-bot
Copy link

@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @vincchan and @MorrisJobke to be potential reviewers

@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 3, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Aug 3, 2016
@@ -31,8 +32,8 @@
'{{/if}}' +
' </div>' +
' <form class="newCommentForm">' +
' <textarea class="message" placeholder="{{newMessagePlaceholder}}">{{{message}}}</textarea>' +
' <input class="submit" type="submit" value="{{submitText}}" />' +
' <input type="text" class="message" placeholder="{{newMessagePlaceholder}}" value="{{{message}}}"" />' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quotes ending

@vincchan
Copy link
Member

vincchan commented Aug 3, 2016

looks really nice and works! :) 👍

@vincchan
Copy link
Member

vincchan commented Aug 3, 2016

failing test

PhantomJS 2.1.1 (Linux 0.0.0) OCA.Comments.CommentsTabView tests editing comments saves message and updates comment item when clicking save FAILED
Expected Object({ message: 'New message' }) to equal Object({ message: 'modified
message' }).
/drone/src/github.com/nextcloud/server/apps/comments/tests/js/commentstabviewSpec.js:335:45

EDIT: also when we're on the subject

editing comments looks a bit weird atm compared to newcomments form

screen shot 2016-08-03 at 13 45 25

@williambargent
Copy link
Member

williambargent commented Aug 3, 2016

Looks much nicer, Works
👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 5, 2016

  • Editing the comment is broken:

bildschirmfoto 2016-08-05 um 16 27 03

@MorrisJobke
Copy link
Member

editing comments looks a bit weird atm compared to newcomments form

-.- Oh ... it was already reported.

@jancborchardt Please fix this ;)

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 5, 2016
@MorrisJobke
Copy link
Member

Beside that it looks nice :)

@rullzer
Copy link
Member

rullzer commented Aug 17, 2016

  • Fixed css
  • fixed js test

Only because it is an input now so you can now longer format text (newlines).
Which might get messed up if you want to edit a comment from a different place that does contain newlines.

I don't really have an opinion here. But let you all decide.

Review time

@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 17, 2016
* tested in IE10, IE11, Edge, Chrome and Firefox
@MorrisJobke
Copy link
Member

I fixed the layout of the submit button and tested it in IE10, 11, Edge, Chrome and Firefox. It now also works properly for all screen sizes.

Before & After:

bildschirmfoto 2016-08-18 um 08 56 25

bildschirmfoto 2016-08-18 um 08 55 22

@MorrisJobke
Copy link
Member

I also fixed the layout of the cancel button (pulled to right and properly aligned). I tested this in Chrome, Firefox, Safari, IE10 and Edge.

Before and after:

bildschirmfoto 2016-08-18 um 09 06 41

bildschirmfoto 2016-08-18 um 09 06 03

@MorrisJobke
Copy link
Member

I tested it and it now works really great 👍 from me

@rullzer
Copy link
Member

rullzer commented Aug 18, 2016

LGTM!

@LukasReschke LukasReschke merged commit 5580a77 into master Aug 18, 2016
@LukasReschke LukasReschke deleted the comments-layout branch August 18, 2016 09:04
@nickvergessen
Copy link
Member

This still had open comments...

Will fix #714 (comment)

@nickvergessen
Copy link
Member

Fix in #928

GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
fix design details in comments sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants