-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add postgresql 10 compatibility to dbal #7210
Conversation
82e5cb7
to
9ca4bd0
Compare
Codecov Report
@@ Coverage Diff @@
## master #7210 +/- ##
============================================
+ Coverage 50.84% 50.87% +0.02%
+ Complexity 24548 24534 -14
============================================
Files 1585 1584 -1
Lines 93804 93770 -34
Branches 1354 1356 +2
============================================
+ Hits 47693 47703 +10
+ Misses 46111 46067 -44
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a drone job for postgres10 so we actually know it works ;)
f903043
to
ab2e268
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@rullzer done |
Please update 3rdparty to contain current master. |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Updated the thirdparty ref. Let's see what CI says :)
Update doctrine/dbal to include doctrine/dbal#2893 and doctrine/dbal#2916 to make it work with postgresql 10