Remove wrong entry in admin_settings that causes 500 #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
schiessle and
blizzz
This was referenced Nov 20, 2017
icewind1991
approved these changes
Nov 20, 2017
rullzer
requested changes
Nov 20, 2017
lib/private/Settings/Manager.php
Outdated
| @@ -471,6 +472,9 @@ public function getAdminSettings($section) { | |||
| $settings[$row['priority']][] = $this->query($row['class']); | |||
| } catch (QueryException $e) { | |||
| // skip | |||
| } catch (AutoloadNotAllowedException $e) { | |||
| // skip error and remove remnant of disabled app | |||
| $this->mapper->remove(Mapper::TABLE_ADMIN_SETTINGS, $row['class']); | |||
There was a problem hiding this comment.
Please log this so we have a trace that it happened.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-autoload-section-failure
branch
from
cdf3fce to
6fd5142
Compare
Codecov Report
@@ Coverage Diff @@
## master #7230 +/- ##
============================================
- Coverage 50.84% 50.84% -0.01%
- Complexity 24547 24548 +1
============================================
Files 1585 1585
Lines 93801 93804 +3
Branches 1354 1354
============================================
Hits 47697 47697
- Misses 46104 46107 +3
|
rullzer
approved these changes
Nov 20, 2017
MorrisJobke
added
4. to release
|
Backport in #7455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up those stale entries and avoids the 500.
Should we maybe backport this to 12?
Fixes #5313
Fixes #5067