generate different UIDs for Birthday, Anniversary and Death event #7707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Codecov Report
@@ Coverage Diff @@
## master #7707 +/- ##
=========================================
Coverage 51.18% 51.18%
Complexity 24948 24948
=========================================
Files 1605 1605
Lines 94925 94925
Branches 1376 1376
=========================================
Hits 48583 48583
Misses 46342 46342
|
|
Thanks for working on this! |
rullzer
reviewed
Jan 8, 2018
| @@ -64,7 +64,7 @@ public function setUp() { | |||
| * @param string | null $data | |||
| */ | |||
| public function testBuildBirthdayFromContact($expectedSummary, $data) { | |||
| $cal = $this->service->buildDateFromContact($data, 'BDAY', '*'); | |||
| $cal = $this->service->buildDateFromContact($data, 'BDAY', '', '*'); | |||
There was a problem hiding this comment.
This seems more like a hack to test it. :) can you also add a test with the proper postfix :P?
rullzer
approved these changes
Jan 24, 2018
|
Let me add more tests, but the actual code will stay unchanged and is ready to be reviewed |
MorrisJobke
approved these changes
Jan 24, 2018
juliusknorr
approved these changes
Jan 24, 2018
ChristophWurst
added
4. to release
This was referenced Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7706
Would like to back port to stable12 and stable13