Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable13] fix(AmazonS3): fix loop $result['Contents'] error #9650

Merged
merged 1 commit into from
May 29, 2018
Merged

[stable13] fix(AmazonS3): fix loop $result['Contents'] error #9650

merged 1 commit into from
May 29, 2018

Conversation

MorrisJobke
Copy link
Member

Backport of #8842

@lanxenet @MorrisJobke
fix(AmazonS3): fix loop $result['Contents'] error
65bb120 
Invalid argument supplied for foreach() at /var/www/html/apps/files_external/lib/Lib/Storage/AmazonS3.php#295
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 29, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 13.0.3 milestone May 29, 2018
@MorrisJobke MorrisJobke mentioned this pull request May 29, 2018
Merged
MorrisJobke
MorrisJobke commented May 29, 2018
View reviewed changes
Copy link
Member Author

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense code wise 👍

blizzz
blizzz approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 29, 2018
@MorrisJobke MorrisJobke merged commit b71c90b into stable13 May 29, 2018
@MorrisJobke MorrisJobke deleted the backport/8842/stable13 branch May 29, 2018 18:56
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@blizzz blizzz blizzz approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 13.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @icewind1991 @blizzz @lanxenet