Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation keyboard accessibility #9951

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix navigation keyboard accessibility #9951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions core/css/apps.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,9 @@ kbd {
padding-left: 38px !important;
}

&:focus,
&:hover,
&:focus,
&:active,
&.active,
a.selected {
&,
Expand All @@ -156,6 +157,13 @@ kbd {
}
}

/* a instead of li is focused by keyboards */
a:focus,
a:active {
opacity: 1;
box-shadow: inset 4px 0 var(--color-primary);
}

/* align loader */
&.icon-loading-small:after {
left: 22px;
Expand Down Expand Up @@ -204,8 +212,8 @@ kbd {
display: inline-flex;
flex-wrap: wrap;
padding-left: 44px;
&:focus,
&:hover,
&:focus,
&.active,
a.selected {
&,
Expand Down Expand Up @@ -488,7 +496,8 @@ kbd {
padding: 5px;
margin-right: 0;
height: 38px;
&:hover {
&:hover,
&:focus {
/* overlapp borders */
z-index: 1;
}
Expand Down Expand Up @@ -537,7 +546,8 @@ kbd {
height: 44px;
width: 44px;
line-height: 44px;
&:hover, &:focus {
&:hover,
&:focus {
opacity: 1;
}
}
Expand Down Expand Up @@ -707,7 +717,8 @@ kbd {
opacity: .57;

&.opened,
&:hover {
&:hover,
&:focus {
background-color: var(--color-main-background);
opacity: 1;
box-shadow: inset 4px 0 var(--color-primary);
Expand Down Expand Up @@ -769,10 +780,13 @@ kbd {
font-weight: 600;
border-bottom: 1px solid var(--color-border);
}
&:hover {
&:hover,
&:focus {
border-bottom: 1px solid var(--color-border);
}
&.selected, &:hover {
&.selected,
&:hover
&:focus {
margin-bottom: 0px;
color: var(--color-main-text);
a {
Expand Down Expand Up @@ -911,7 +925,9 @@ $popovericon-size: 16px;
&[class*=' icon-'] {
padding: 0 #{($popoveritem-height - $popovericon-size) / 2} 0 $popoveritem-height !important;
}
&:hover, &:focus, &.active {
&:hover,
&:focus,
&.active {
opacity: 1 !important;
}
/* prevent .action class to break the design */
Expand Down Expand Up @@ -1056,13 +1072,15 @@ $popovericon-size: 16px;
padding: 22px;
opacity: .3;
cursor: pointer;
&:hover, &:focus {
&:hover,
&:focus {
opacity: .7;
}
&[class^='icon-star'],
&[class*=' icon-star'] {
opacity: .7;
&:hover, &:focus {
&:hover,
&:focus {
opacity: 1 ;
}

Expand All @@ -1073,7 +1091,8 @@ $popovericon-size: 16px;
}
}

&:hover, &:focus,
&:hover,
&:focus,
&.active {
background-color: var(--color-background-dark);
}
Expand Down