Resend activation email for new users as admin #9966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
3. to review
skjnldsv
requested review from
rullzer,
MorrisJobke,
jancborchardt,
juliusknorr and
danxuliu
skjnldsv
force-pushed
the
resend-welcome-email
branch
from
43e8611 to
dec9181
Compare
Codecov Report
@@ Coverage Diff @@
## master #9966 +/- ##
========================================
Coverage 31.7% 31.7%
Complexity 26017 26017
========================================
Files 1660 1660
Lines 96167 96167
Branches 1290 1290
========================================
Hits 30490 30490
Misses 65677 65677 |
|
Rebase to fix the conflicts ;) |
skjnldsv
force-pushed
the
resend-welcome-email
branch
2 times, most recently
from
976177f to
9c7b969
Compare
|
Gents, great to hear! what about extending the timeout for activation from 24h to 48 or 96 or longer? |
|
@JK74 it's not the same issue though. Could you check if there is not already an issue on this? |
|
Yes will do but it's an alternative solution as I think most people like to see the resolution in 2 ways: manual re-submission and extensing the activation time |
skjnldsv
force-pushed
the
resend-welcome-email
branch
from
9c7b969 to
3df49b7
Compare
|
Rebased. |
rullzer
reviewed
Jun 26, 2018
settings/js/settings-vue.js
Outdated
| @@ -40,7 +40,11 @@ var n="undefined"!=typeof window&&"undefined"!=typeof document,r=["Edge","Triden | |||
| * vue-router v3.0.1 | |||
| * (c) 2017 Evan You | |||
| * @license MIT | |||
| <<<<<<< HEAD | |||
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
resend-welcome-email
branch
from
3df49b7 to
d3d357f
Compare
rullzer
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6023
@nextcloud/designers @jonasgarstick