Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial try to support illumos/Solaris to fix #263. #264

Closed
wants to merge 3 commits into from
Closed

Initial try to support illumos/Solaris to fix #263. #264

wants to merge 3 commits into from

Conversation

dertuxmalwieder
Copy link

No description provided.

@kesselb
Copy link
Collaborator

kesselb commented Jan 15, 2023

Hi, can you rebase your branch to pull the latest changes?

@dertuxmalwieder
Copy link
Author

I have ceased any hope that this will ever be considered, to be honest.

@kesselb
Copy link
Collaborator

kesselb commented Jan 15, 2023

Sorry, it took so long to respond to your pull request 😞

I think we need to merge #411 first and update your implementation afterward.

Could you run php -r "var_export(net_get_interfaces());" to export the network interfaces on your server?
I would like to know if the function also works on your sunos.
Don't forget to replace your public ip address with a private one if necessary.

@dertuxmalwieder
Copy link
Author

Sure - here's the output:

array (
  'lo0' =>
  array (
    'unicast' =>
    array (
      0 =>
      array (
        'flags' => 137455732809,
        'family' => 2,
        'address' => '127.0.0.1',
        'netmask' => '255.0.0.0',
      ),
      1 =>
      array (
        'flags' => 137472510025,
        'family' => 26,
        'address' => '::1',
        'netmask' => 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff',
      ),
    ),
    'up' => true,
  ),
  'vioif0' =>
  array (
    'unicast' =>
    array (
      0 =>
      array (
        'flags' => 16795715,
        'family' => 2,
        'address' => '[redacted]',
        'netmask' => '255.255.252.0',
        'broadcast' => '[redacted]',
      ),
    ),
    'up' => true,
  ),
)

@kesselb
Copy link
Collaborator

kesselb commented Jan 28, 2023

#411 is merged.

Could you update your pull request to use the new NetInterface logic?

@dertuxmalwieder
Copy link
Author

dertuxmalwieder commented Jan 30, 2023

Could you update your pull request to use the new NetInterface logic?

I honestly don't know - you completely changed almost everything and now I'll need to understand WTH you did. Maybe it would have been nice to communicate with me during the production of the several changes. As of now, I have no idea what I should do to support all of it. Closing this PR for now.

You could have merged my PR first to make it easier for everyone. You had two years...

I give up for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants