Follow-up(Edit message)

[DorraJaouad]

Follow-up to #11374

To do 🚧

• Mention parsing for the input
• Add hint
  
• Improve edit history design in MessageButtonsBar
  
• Error handling (showError + keep the edit on)
• Handle capabilities (for Talk Desktop) feat(chat): Add capability for editing messages #11408
  • delete-messages-unlimited
  • edit-messages
• Move edit option above "Delete message"
• Interactive checklist in messages #11402

[DorraJaouad]

@nextcloud/designers, could you please share some feedback on these points:

• The hint "Adding a mention ..." will be a NcNoteCard. Is it okay in terms of the spacing ? It is not shown only if a user edits a message and add a mention.
• "Last edit info" design in MessageButtonsBar
• Should the edit message button be moved above delete button ?
  

You can refer to #11374 for the basic edit feature screenshots

[szaimen]

• The hint "Adding a mention ..." will be a NcNoteCard. Is it okay in terms of the spacing ? It is not shown only if a user edits a message and add a mention.

I don't see this on the screenshot, do I see it somewhere?

• "Last edit info" design in MessageButtonsBar

Looks good but I would show the time before the date...

• Should the edit message button be moved above delete button ?

It is alreaddy above it in the screenshot?

[DorraJaouad]

I don't see this on the screenshot, do I see it somewhere?

It's the yellow line

It is alreaddy above it in the screenshot?

Currently, it is here

[jancborchardt]

I don't see this on the screenshot, do I see it somewhere?

It's the yellow line

This doesn’t look like NcNoteCard though? If it would be NcNoteCard then it would be fine. :)

---

It is alreaddy above it in the screenshot?

Currently, it is here

This seems good to me, however the detail list as per this screenshot could be improved. There is strange spacing between the nickname and the time. We would probably have to make it 2-line, so that it’s "Edited by Simon Lindner" in the first line (as we shouldn’t just show account names there and they might be long) and the date in the subline

Similar to how it is on iOS as per the comment #11203 (comment)

[DorraJaouad]

Currently, the author+timestamp line is like this :

The line will expand depending on the username length.

so that it’s "Edited by Simon Lindner" in the first line (as we shouldn’t just show account names there and they might be long) and the date in the subline

I am worried that it will be a bit confusing to see 2 dates and each is on a line ( sent timestamp and edited timestamp). There should be way to distinguish between them (like change the edited stamp text color to secondary ?) .

[nickvergessen]

Currently, the author+timestamp line is like this :

Can you use a "real name" as sample in the screenshot so we see it wrap (rebasing on latest master should give you the display name)

[jancborchardt]

I am worried that it will be a bit confusing to see 2 dates and each is on a line ( sent timestamp and edited timestamp). There should be way to distinguish between them (like change the edited stamp text color to secondary ?) .

Sure, sounds good! :) Then let's indeed use colore-text-maxcontrast for the timestamp of any edits (not for the main timestamp), and also separate the name and timestamp with a middle dot like so:

Simon Lindner · Jan 17, 2024 3:42 PM

[DorraJaouad]

Option 1 (as iOS shows only time, and you can edit within 24 hours)

| ||

Option 2
|

[SystemKeeper]

Option 1 (as iOS shows only time, and you can edit within 24 hours)

Just for clarification, iOS shows the time only when it happened today, otherwise it shows date and time