Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(messages): Edit messages #11374

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 11, 2024

☑️ Resolves

  • Editing a message in a group of messages split the group at the edited message.
  • After completing edit or aborting it, it should resume the previous input.
  • Edit in default input showing the original content as a "quote"
    • Don't allow changing from message to caption and vice-versa
    • Don't allow to toggle silent send on
  • System message hidden like with delete?
  • Visible indicator a message was edited (and by whom/when)?
    • Amend to the author name (edited) / (edited by moderator-name)
    • Editor+Time in Message menu as subline of timestamp
  • Time limitation like for delete?
    • Limit editing to X hours (draft 24 hours, check what others do and discuss again)
    • Set the limit on deletion to infinite
  • What to do about mention notifications (added a mention, removed a mention)?
    • Should indicate in the UI what happens (only when affected)
    • Make sure people don't get 1 for the message and 2 for followup edits
  • What about bots?
    • Can not edit bot messages, moderators can
    • Bots will not get explicitly notified about previous edits (only with the default system message)?
    • If a message triggered a bot already it's yolo and will not be retriggered with the new content automatically (bot can do based on the system message?)
      • Should indicate in the UI what happens (only when affected)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Message Menu
image image
image
image image

🚧 Tasks

  • Visual review
  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Jan 11, 2024
@DorraJaouad DorraJaouad added this to the 💞 Next Major (29) milestone Jan 11, 2024
@DorraJaouad DorraJaouad self-assigned this Jan 11, 2024
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of remarks, while you're still working on it

src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/Quote.vue Outdated Show resolved Hide resolved
src/services/messagesService.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/11205/edit-message-frontend branch 2 times, most recently from ed8aa45 to 9389f8c Compare January 12, 2024 18:04
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/11205/edit-message-frontend branch from 9389f8c to 6daa822 Compare January 15, 2024 11:36
@DorraJaouad DorraJaouad marked this pull request as ready for review January 15, 2024 11:49
src/stores/chatExtras.js Outdated Show resolved Hide resolved
src/stores/__tests__/chatExtras.spec.js Outdated Show resolved Hide resolved
src/stores/__tests__/chatExtras.spec.js Outdated Show resolved Hide resolved
src/services/messagesService.js Show resolved Hide resolved
src/components/Quote.vue Outdated Show resolved Hide resolved
src/components/ChatView.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/ChatView.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/11205/edit-message-frontend branch 2 times, most recently from 888b0d3 to 6bcccc7 Compare January 17, 2024 14:43
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far good

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/11205/edit-message-frontend branch from 6bcccc7 to c3799f2 Compare January 17, 2024 15:49
@DorraJaouad DorraJaouad merged commit ae3de4c into main Jan 17, 2024
36 checks passed
@DorraJaouad DorraJaouad deleted the feat/11205/edit-message-frontend branch January 17, 2024 16:36
@DorraJaouad DorraJaouad mentioned this pull request Jan 18, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✏️ Edit message - Frontend
3 participants