Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(messages): Edit messages #11374

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Feat(messages): Edit messages #11374

merged 9 commits into from
Jan 17, 2024
+374 −22

Commits on Jan 15, 2024

  1. Implement base edit function 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    13a3a59 View commit details
    Browse the repository at this point in the history

  2. Process message and add visual indicators 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    7b47d05 View commit details
    Browse the repository at this point in the history

  3. Restrict the ability to edit a message 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    34f6e6d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Prevent changes from simple message to caption 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    91c46d0 View commit details
    Browse the repository at this point in the history

  2. Split input states and split groups at edited messages 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9946917 View commit details
    Browse the repository at this point in the history

  3. Disable edit when text is empty or is the same as the original message 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f3001d1 View commit details
    Browse the repository at this point in the history

  4. Add tests and revert some added conditions 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ea531ef View commit details
    Browse the repository at this point in the history

  5. Improve wording and UI 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f95bce0 View commit details
    Browse the repository at this point in the history

  6. Last fixes 

    Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
    @DorraJaouad
    DorraJaouad committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c3799f2 View commit details
    Browse the repository at this point in the history