Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to disable specific or all chat embeds (Mainly for Nextcloud Office) #13685

Open
ThibautPlg opened this issue Nov 4, 2024 · 2 comments

Comments

@ThibautPlg
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: NC28 or newer

Is your feature request related to a problem? Please describe.
We are using Nextcloud talk daily for our meetings and are often referencing Nextcloud Office documents. That can be a list of documents, notes for futures edits or simply a link for meeting participants to open and start editing. However, the automatic Collabora iframe is always instantiated in the chat, bringing some problems:

  • Chat flow is interrupted by a big iframe
  • Scrolling for past messages also adds iframes
  • Every iframe loading is quite painful, slow and adds up to an already heavy memory consuming browser tab
  • Every meeting participant is then shown in duplicate (one from the chat, one from the actual Collabora tab)
  • Can cause unwanted files locking mechanisms if someone is browsing the chat without wanting to edit any documents

These problems are more important with the Collabora integration, but same can be said for other Nextcloud apps (even text!) that appears as iframes.

A quick performance review using Firefox's about:performance tab inspector.

  • Nextcloud Talk homepage: 375Mb
  • Nextcloud Talk random conversation: 422Mb
  • Nextcloud Talk conversation with Collabora: 816Mb

Opening a Nextcloud Talk conversation without even being in a call already eats up 800Mb of ram. These numbers can and will vary depending on every browser, hardware, Nextcloud and whatever, but that gives a nice idea of the performance issue introduced solely by the iframes imo.

Describe the solution you'd like
The ability to disable Collabora's iframes embeds. If not possible or too difficult, the ability to disable all embeds.
Disabling Collabora embeds would have little to no impact for us as the iframe is too little to do any work anyway.

Describe alternatives you've considered
Pasting Nextcloud files links to the chat with a typo or a space to prevent iframes instantiating


Best regards,

@Antreesy
Copy link
Contributor

Antreesy commented Nov 4, 2024

Hi, thanks for the report!
We're waiting for this PR to be released: nextcloud-libraries/nextcloud-vue#6151
Then we'll discuss, whether widgets in the chat should be the always disabled, or disabled by default and then configured by user

@Antreesy Antreesy self-assigned this Nov 4, 2024
@Antreesy Antreesy added this to the 🧡 Next Patch (28) milestone Nov 4, 2024
@ThibautPlg
Copy link
Author

I checked for opened issues but not PRs even less in nextcloud-vue lib. Thanks :) Looking forward to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants