Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcRichText): make interactive widgets opt-in #6151

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Do not load widget integration by default (if embedded e.g. in Talk)
  • Fix min-height of list (test 'before' -> when loading is done, list shrinks)
  • Make toggle button present (remove opacity, move to corner)

🖼️ Screenshots

🏚️ Before

Animotica_17_10_16_30_6.mp4

🏡 After

Animotica_17_10_16_27_43.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…hText

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Oct 17, 2024
@Antreesy Antreesy added this to the 8.20.0 milestone Oct 17, 2024
@Antreesy Antreesy requested a review from ShGKme October 17, 2024 14:33
@Antreesy Antreesy self-assigned this Oct 17, 2024
@ShGKme ShGKme changed the title feat: make interactive widgets opt-in from NcRichText feat(NcRichText): make interactive widgets opt-in Oct 17, 2024
Comment on lines +320 to +321
bottom: var(--default-grid-baseline);
right: var(--default-grid-baseline);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it looks better, but it can overflow the content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider:

  • make a button semi-transparent when not hovered;
  • make it icon button (and put text in title/aria-label

Don't see it moved outside of widget area

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/noid/reference-fixups branch from afc266d to 98b4fc9 Compare October 18, 2024 09:35
@Antreesy Antreesy requested a review from DorraJaouad October 18, 2024 09:47
@Antreesy
Copy link
Contributor Author

/backport to next

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 👍🏻

@Antreesy Antreesy merged commit 6305066 into master Oct 18, 2024
19 checks passed
@Antreesy Antreesy deleted the feat/noid/reference-fixups branch October 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants