chore: bump @nextcloud/vue to v8.0.0-beta.8 #10626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
2. developing
design
feature: frontend 🖌️
Antreesy
force-pushed
the
deps/nextcloud/vue-8.0.0-beta.7
branch
2 times, most recently
from
7cb5c08
to
41a3277
Compare
Antreesy
force-pushed
the
deps/nextcloud/vue-8.0.0-beta.7
branch
from
425abd0
to
9baf377
Compare
Antreesy
changed the title
Antreesy
force-pushed
the
deps/nextcloud/vue-8.0.0-beta.7
branch
from
9baf377
to
5acdc26
Compare
| @@ -706,6 +706,11 @@ export default { | |||
| const possibleMentions = response.data.ocs.data | |||
|
|
|||
| possibleMentions.forEach(possibleMention => { | |||
| // TODO fix backend for userMention | |||
There was a problem hiding this comment.
We can not, because other clients rely on the naming,
There was a problem hiding this comment.
Then I'll guess it will be better to patch response on web-client only, rather then provide both label and name?
DorraJaouad
reviewed
Oct 10, 2023
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
ShGKme
reviewed
Oct 10, 2023
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
deps/nextcloud/vue-8.0.0-beta.7
branch
from
5acdc26
to
a7c1ed7
Compare
ShGKme
reviewed
Oct 10, 2023
ShGKme
reviewed
Oct 10, 2023
Set height to 100%, align icon within empty space Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Fix scroll and paddings due to new wrapper, fix close button Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Replace *title prop => *name prop Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
rename import, remove deep styles, fix appearance Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…cDateTimePicker rename imports, remove or replace outdated props Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
transform backend response for UserMention Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
rename *title => *name props, adjust tests, remove deep styles Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
deps/nextcloud/vue-8.0.0-beta.7
branch
from
a7c1ed7
to
948a640
Compare
DorraJaouad
approved these changes
Oct 11, 2023
|
|
||
| &__loading, | ||
| &__empty-content { | ||
| flex: 1; |
There was a problem hiding this comment.
No need to ? as empty content has flex-grow: 1
There was a problem hiding this comment.
Only for &__loading seems to be required.
There was a problem hiding this comment.
Will fix in a follow-up 👀
ShGKme
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@nextcloud/vueto v8.0.0-beta.8🖼️ Screenshots
🚧 Tasks
fix backend for NcAutocompleteResult (provide title instead of label or both)provide compatibility for frontend and mobile clients (endpoint:chat/{token}/mentions)n/no-missing-importfor library components🏁 Checklist
docs/has been updated or is not required