Add metadata to file parameters

[SystemKeeper]

☑️ Resolves

• Fix Include image metadata #10844

I tried to take a look at #10844. Leaving the tests and documentation aside, is this the correct way to solve it or would we need to take another different approach regarding performance?

🛠️ API Checklist

🚧 Tasks

• Correct the comment
• Needs nextcloud/OCP update after tonight

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not possible
• 📘 API documentation in docs/ has been updated or is not required
• 🔖 Capability is added or not needed

[SystemKeeper]

Guess we would need to add that to https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L316 as well?

[nickvergessen]

Guess we would need to add that to https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L316 as well?

I was about to comment that as well, but we have more keys already which are not there (e.g. contact-photo) which are very specific. In most cases the info will not be exposed when when it could be available via other APIs, so not sure it's the best idea, as it could make people assume ah, didn't get data, doesn't work, instead of trying the official API endpoint

[SystemKeeper]

Okay, so guess ready to review then :)

[SystemKeeper]

CC: @mahibi In case that would be useful for you as well

[nickvergessen]

/backport to stable28

[Antreesy]

Won't there be any good use of this for web? I'd see if we could reserve the space for images beforehand to avoid a chat jumping

[nickvergessen]

Won't there be any good use of this for web? I'd see if we could reserve the space for images beforehand to avoid a chat jumping

Just had the same thought, maybe that is the problem of the jumping chats we have on loading.
So feel free to use the data and we then remove the user agent check

[SystemKeeper]

I'd see if we could reserve the space for images beforehand to avoid a chat jumping

That's exactly the reason for this PR. Dynamically changing the height of cells while keeping the scroll position is a super hard task with the components we are currently using in iOS. This way we could reserve the space and know beforehand how big the preview will be. It would get even better with the blurhash, but this seems to be missing in 28.