-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meetings): selectively invite users from lobby #11395
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
I would say it should be even more visible? Directly show it on the participant list next to the ...? |
src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
Outdated
Show resolved
Hide resolved
406767a
to
e8bfa51
Compare
Updated code, icons (unlock/lock for account fit more IMO) and screenshots |
Not sure about the wording of the buttons. cc @jancborchardt for better ideas |
Improved wording could be:
"Move" seems more fitting than "invite" since it is a direct action, right? |
Agree. Maybe Any thoughts over icons used? |
src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/Participants/ParticipantsList/Participant/Participant.vue
Outdated
Show resolved
Hide resolved
I would use the short wording. We want to phase out the wording "user", and the text is long enough already. :)
Yep, wrote as reply in @DorraJaouad's code comment. |
Also note this is not only about "users", but also about "guests". |
Or not use it at all, to keep it short (same is done for 'Promote / demote to moderator') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
… user Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
55b197b
to
ce182a7
Compare
☑️ Resolves
isInLobby
was removed fromchatIdentifier
:Important
HPB is required to be enabled, to receive signaling messages
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
lobby-permissions.mp4
🚧 Tasks
🏁 Checklist