Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meetings): selectively invite users from lobby #11395

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 17, 2024

☑️ Resolves

  • Fix Direct option to allow a user to join while the lobby is enabled #8601
  • If lobby is enabled, a new button is appeare in participant action to explicitly change lobby permission for that one participant
  • isInLobby was removed from chatIdentifier:
    • chat is mounted/unmounted with param change anyway, so no need to depend on it
    • it leaves outdated cancel requests in the store:
      image

Important

HPB is required to be enabled, to receive signaling messages

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

In Out
image image
lobby-permissions.mp4

🚧 Tasks

  • Check wording
  • Decide on selected icons

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby labels Jan 17, 2024
@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Jan 17, 2024
@Antreesy Antreesy self-assigned this Jan 17, 2024
@nickvergessen
Copy link
Member

I would say it should be even more visible? Directly show it on the participant list next to the ...?

@Antreesy Antreesy force-pushed the feat/8601/invite-users-to-lobby branch from 406767a to e8bfa51 Compare January 17, 2024 17:14
@Antreesy
Copy link
Contributor Author

I would say it should be even more visible?

Updated code, icons (unlock/lock for account fit more IMO) and screenshots

@nickvergessen
Copy link
Member

Not sure about the wording of the buttons. cc @jancborchardt for better ideas

@jancborchardt
Copy link
Member

Improved wording could be:

  • Move to conversation
  • Move back to lobby

"Move" seems more fitting than "invite" since it is a direct action, right?

@Antreesy
Copy link
Contributor Author

"Move" seems more fitting than "invite" since it is a direct action, right?

Agree. Maybe Move user would be more explicable, but I'm fine with short option too
Participant is already in the conversation, but can't think of other wording, so could proceed with that.

Any thoughts over icons used?

@jancborchardt
Copy link
Member

"Move" seems more fitting than "invite" since it is a direct action, right?

Agree. Maybe Move user would be more explicable, but I'm fine with short option too
Participant is already in the conversation, but can't think of other wording, so could proceed with that.

I would use the short wording. We want to phase out the wording "user", and the text is long enough already. :)

Any thoughts over icons used?

Yep, wrote as reply in @DorraJaouad's code comment.

@nickvergessen
Copy link
Member

We want to phase out the wording "user", and the text is long enough already. :)

Also note this is not only about "users", but also about "guests".
That's why we use the word "participant" e.g. on the remove option. Should use it here too.

@Antreesy
Copy link
Contributor Author

Should use it here too.

Or not use it at all, to keep it short (same is done for 'Promote / demote to moderator')

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

… user

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/8601/invite-users-to-lobby branch from 55b197b to ce182a7 Compare January 22, 2024 14:51
@Antreesy Antreesy merged commit e9c7ad9 into main Jan 22, 2024
36 checks passed
@Antreesy Antreesy deleted the feat/8601/invite-users-to-lobby branch January 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct option to allow a user to join while the lobby is enabled
4 participants