Add appId to unified search add filter event object #11672
Conversation
There was a problem hiding this comment.
The text "In converstion" can also be changed in this PR.
@nickvergessen you suggested that it is changed to "Messages"? (NB, there is already a messages filter from the backend)
cc: @jancborchardt
nfebe
force-pushed
the
extend-unified-plugin-filter-object
branch
from
b83a011
to
e26f033
Compare
|
Hi! Seems OK, please follow https://www.conventionalcommits.org/en/v1.0.0/ for commit messages |
nfebe
force-pushed
the
extend-unified-plugin-filter-object
branch
2 times, most recently
from
1e7a1ba
to
5d31c79
Compare
Oops, sorry just realized that the conventional commit style is being enforced. |
Due the need to group filters by app, in the core, it's neccesary that filters, it's neccesary that plugin filters come with a field that helps identify the app that sent in the filter. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nickvergessen
force-pushed
the
extend-unified-plugin-filter-object
branch
from
5d31c79
to
6b5bc4d
Compare
|
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Due the need to group filters by app, in the core, it's neccesary that filters, it's neccesary that plugin filters come with a field that helps identify the app that sent in the filter.
UI