feat(MessageBody): apply checkbox interactivity #12063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
feat/11402/checkbox-interactivity
branch
from
91501ea
to
4319499
Compare
Antreesy
approved these changes
Apr 11, 2024
Antreesy
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Oh, and also should message should be editable
Please refer to the #11402 (comment)
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
| let checkBoxIndex = 0 | ||
| const lines = this.message.split('\n') | ||
| for (let i = 0; i < lines.length; i++) { | ||
| if (lines[i].trim().match(/^- {1,4}\[\s\]/) || lines[i].trim().match(/^- {1,4}\[x\]/)) { |
There was a problem hiding this comment.
could be more that 4 spaces. Maybe use ^\s*-\s+\[(\s|x)\]?
There was a problem hiding this comment.
between - and [ ] ?
There was a problem hiding this comment.
I assume you are referring to the spaces before -, trim() is there for that.
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Show resolved
Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
feat/11402/checkbox-interactivity
branch
from
4319499
to
dab36c8
Compare
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Recording.2024-04-11.152411.mp4
🏁 Checklist