Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌇 fix(chat): Remove commands #12076

Merged
merged 2 commits into from
Apr 12, 2024
Merged

🌇 fix(chat): Remove commands #12076

merged 2 commits into from
Apr 12, 2024

Conversation

nickvergessen
Copy link
Member

👋

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: bots 🤖 /commands in chat messages labels Apr 12, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone Apr 12, 2024
@nickvergessen nickvergessen self-assigned this Apr 12, 2024
SystemKeeper
SystemKeeper approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ByeBye

@nickvergessen
fix(chat): Remove commands
cc4e292 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Antreesy
Antreesy approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR

@nickvergessen
fix(commands): Also remove tests
9a7f305 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit e5a0c10 into main Apr 12, 2024
63 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/remove-commands branch April 12, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: bots 🤖 /commands in chat messages feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @SystemKeeper @Antreesy