Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(teams): Add a test to check if "Shared with team" allows chatting #12240

Merged
merged 2 commits into from
Jun 14, 2024
Merged

test(teams): Add a test to check if "Shared with team" allows chatting #12240

merged 2 commits into from
Jun 14, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 29, 2024 •
edited
Loading

🛠️ API Checklist

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Apr 29, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone Apr 29, 2024
@nickvergessen nickvergessen self-assigned this Apr 29, 2024
@nickvergessen nickvergessen marked this pull request as draft April 29, 2024 09:19
@nickvergessen nickvergessen force-pushed the bugfix/noid/allow-file-chat-when-shared-with-team branch from c4ef704 to 8896729 Compare April 29, 2024 09:25
@nickvergessen nickvergessen mentioned this pull request May 2, 2024
Open
@nickvergessen nickvergessen force-pushed the bugfix/noid/allow-file-chat-when-shared-with-team branch from 8896729 to 45c315b Compare June 5, 2024 15:02
@nickvergessen
test(teams): Add a test to check if "Shared with team" allows chatting
e0ba1e7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/allow-file-chat-when-shared-with-team branch from 45c315b to e0ba1e7 Compare June 13, 2024 10:58
@nickvergessen nickvergessen marked this pull request as ready for review June 13, 2024 10:58
SystemKeeper
SystemKeeper reviewed Jun 13, 2024
View reviewed changes
.github/workflows/integration-oci.yml Outdated Show resolved Hide resolved
.github/workflows/integration-pgsql.yml Outdated Show resolved Hide resolved
.github/workflows/integration-sqlite.yml Outdated Show resolved Hide resolved
@nickvergessen
fix(CI): Bump checkout action version
644841b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
SystemKeeper
SystemKeeper approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nickvergessen nickvergessen merged commit 7b53bdd into main Jun 14, 2024
115 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/allow-file-chat-when-shared-with-team branch June 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@skalidindi53 skalidindi53 Awaiting requested review from skalidindi53

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper