Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MediaSettings): add option to mirror video preview #12580

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat(MediaSettings): add option to mirror video preview #12580

merged 1 commit into from
Jun 27, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

☀️ Light theme 🌑 Dark Theme
Screenshot from 2024-06-26 11-09-39 image
Screenshot from 2024-06-26 11-09-23 image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jun 26, 2024
@Antreesy Antreesy self-assigned this Jun 26, 2024
jancborchardt
jancborchardt approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice solution! :)
One little enhancement, the sentence for yourself could be adjusted to:

Display video as you will see it (mirrored)

DorraJaouad
DorraJaouad approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
@Antreesy
feat(MediaSettings): add option to mirror video preview
1db75b2 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12545/mirror-local-video branch from b8f9eff to 1db75b2 Compare June 27, 2024 07:20
@Antreesy Antreesy enabled auto-merge June 27, 2024 07:21
@Antreesy
Copy link
Contributor Author

/backport to stable29

@Antreesy Antreesy merged commit adf775f into main Jun 27, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12545/mirror-local-video branch June 27, 2024 07:46
@backportbot backportbot bot mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Background image is mirror-inverted on own video stream
4 participants
@Antreesy @jancborchardt @ShGKme @DorraJaouad