Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): disable call buton if talk proxy hash is dirty #12879

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 1, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Moved toast to the top to see call button on th screenshot

image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible - in follow-up
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

-'config-local' is an array of string, whereas 'config' is an object with key-value pairs

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@nickvergessen
Copy link
Member

Not sure if we should allow chat with dirty hash (as we did before), but feels like we need to

We should allow it, so people can recover their input etc. Also most of the settings don't touch chatting at all.

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12864/fix-remote-capabilities branch from 3d04573 to aa637f3 Compare August 1, 2024 18:57
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Unrelated to this pull request, joining a federated conversation for the first time after logging in shows the Nextcloud Talk Federation was updated, please reload the page message. From the code it makes sense, as the capabilities would not be found in the browser storage so the hash can not match, but from a user point of view looks like a bug. I think that I read somewhere that this was a known issue, but I mention it just in case.

@Antreesy Antreesy changed the title fix(federation): disable chat and call if talk hash is dirty fix(federation): disable call buton if talk proxy hash is dirty Aug 2, 2024
@Antreesy Antreesy merged commit f00266d into main Aug 2, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12864/fix-remote-capabilities branch August 2, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call button should be disabled when federated capabilities were updated
3 participants