-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: request fullscreen for the whole page #13320
Conversation
store.dispatch('setMainContainerSelector', '#talk-sidebar') | ||
store.dispatch('setMainContainerSelector', 'body') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this state now, if it is always body
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set to body
, so it's not affecting components now. Want to move a clean-up of that store/state to the follow-up PR, since it's touching too many files
(NewMessage is broken now, if state is undefined)
a0c6374
to
d395921
Compare
- header should be hidden, and app-content stretched to the whole viewport, so apply custom styles Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- Viewer is always mounted next to the #content-vue, so it will be visible on body fullscreen-ed Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
d395921
to
a37fbf0
Compare
/backport to stable30 |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist
Signed-off-by: Maksim Sukharev antreesy.web@gmail.com