fix(TopBar): migrate to NcPopover #13332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
added
bug
enhancement
feature: frontend 🖌️
Antreesy
reviewed
Sep 18, 2024
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
fix/13328/top-bar
branch
from
6391067
to
7094a2c
Compare
|
/backport to stable30 |
ShGKme
reviewed
Sep 19, 2024
Comment on lines
+42
to
+44
| :triggers="['hover']"> | ||
| <template #trigger="{ attrs }"> | ||
| <p v-bind="attrs" |
There was a problem hiding this comment.
<p> cannot have aria- attributes from attr, it is not valid.
But it is also not valid to make <p> an interactive trigger...
There was a problem hiding this comment.
it's already inside of <a>, which triggers settings dialog to open, and <p> only listening to mouseover
So, not much we can do?
Antreesy
reviewed
Sep 25, 2024
| {{ conversation.description }} | ||
| </p> | ||
| </template> | ||
| <NcPopover v-if="conversation.description" |
There was a problem hiding this comment.
Just noticed, that popover might be wider than a description:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist