feat(reactions): Add 👋 and 🔥 call reactions #13345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
enhancement
feature: call 📹
nickvergessen
requested review from
SystemKeeper,
mahibi,
DorraJaouad and
Antreesy
SystemKeeper
requested changes
Sep 19, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
Antreesy
force-pushed
the
feat/13343/wave-emoji-reaction
branch
from
93a88f8
to
22693b9
Compare
|
Question arise: how it's supposed to work in federated calls with older versions? UPD: tested with stable30, old version has a fallback emoji, but not a gif. Apart from it, reactions are working properly |
SystemKeeper
approved these changes
Sep 19, 2024
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist
docs/has been updated or is not required