Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Recover broken invites #13406

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix(federation): Recover broken invites #13406

merged 2 commits into from
Sep 30, 2024
+27 −5

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 26, 2024 •
edited
Loading

🛠️ API Checklist

👣 Steps

  1. Invite User2 from Remote2
  2. Simulate a disconnect, by either:
    a. Disable Remote2 and then delete User2 on Remote1
    b. or directly remote User2 from attendees table on Remote1
  3. Re-invite User2 from Remote2 to the same room

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(federation): Update invitation information when receiving a re-in…
3161484 
…vite

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Sep 26, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Sep 26, 2024
@nickvergessen nickvergessen self-assigned this Sep 26, 2024
@nickvergessen nickvergessen marked this pull request as draft September 26, 2024 16:00
@nickvergessen nickvergessen force-pushed the bugfix/noid/recover-broken-invites branch from 31c7683 to 4dd39b1 Compare September 27, 2024 14:52
@nickvergessen nickvergessen marked this pull request as ready for review September 27, 2024 14:53
@nickvergessen
fix(federation): Also reset information for the attendee
04febb2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/recover-broken-invites branch from 4dd39b1 to 04febb2 Compare September 30, 2024 09:50
@nickvergessen nickvergessen merged commit 2dcd203 into main Sep 30, 2024
68 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/recover-broken-invites branch September 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skalidindi53 skalidindi53 skalidindi53 approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @skalidindi53