Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faulty avatars for guests and deleted users #13733

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 7, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image
🏚️ Before 🏡 After
image image

🚧 Tasks

  • Follow-up: do not pass 'Guest' to AvatarWrapper

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/utils/getDisplayName.ts Outdated Show resolved Hide resolved
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit 91af82e into main Nov 11, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/13716/deleted-users-icon branch November 11, 2024 15:15
@Antreesy
Copy link
Contributor Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim whitespaces in guest names
2 participants