Move room moderation actions to a menu #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That breaks exactly what it was protecting against:
|
No, it does not for two reasons:
|
|
Ah the editable Name thing moved the event listener to another view... |
|
The moderator menu can not be opened via keyboard (it immediatelly closes again) |
nickvergessen
approved these changes
Aug 28, 2019
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
In Nextcloud 17 "OC._currentMenu" was removed, so "renderWhenInactive()" always renders immediately. Instead of fixing that the method was completly removed, as keeping the menu open instead of rendering again the view does not provide much value (if the room is no longer public the password will be unusable anyway, and having the password menu open when another moderator sets or removes the password should not happen too often). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The password input is no longer the only element of the menu so pressing "Esc" does not close the menu. There is no longer a password button in the CallInfoView, so now the acceptance tests need to open the room moderation menu to know if the conversation is password protected or not. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The same "Copy link" button was defined separately in the templates for moderators and non moderator participants. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "share-link-options" element acts as a spacer to move the room moderation menu button to the right. However, given that the call button width is limited to the 50% of its parent flex element and that element has the full width of the sidebar the same effect can be achieved by setting "margin-left: auto" on the room moderation button. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The rules just set the same values used by buttons by default. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Now that the management actions were moved to a menu there is enough room to show a label for the "Copy link" button. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
move-room-moderation-actions-to-a-menu
branch
from
1c5cd17 to
3e3506b
Compare
You need nextcloud/server#16863 |
|
That fixes it, right 👍 |
delete-merged-branch
bot
deleted the
move-room-moderation-actions-to-a-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until #2122 is merged (first commit of this pull request is Move checkbox to change between public and group room to a menu)
This pull request provides the groundwork needed to set the lobby state in the UI using a menu