Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contacts menu integration #300

Merged
merged 3 commits into from
Apr 26, 2017
Merged

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Apr 26, 2017

  • Start a call with the user (internal users only) selected in contacts menu.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Ivansss and others added 2 commits April 26, 2017 12:12
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Works here, good to merge?

@Ivansss
Copy link
Member Author

Ivansss commented Apr 26, 2017

Works fine here as well 👍

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #300 into master will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
- Coverage     15.72%   15.46%   -0.26%     
- Complexity      269      274       +5     
============================================
  Files            17       18       +1     
  Lines          1272     1293      +21     
============================================
  Hits            200      200              
- Misses         1072     1093      +21
Impacted Files Coverage Δ Complexity Δ
lib/ContactsMenu/Providers/CallProvider.php 0% <0%> (ø) 4 <4> (?)
lib/Controller/PageController.php 0% <0%> (ø) 16 <8> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bdc76c...ea2d2a4. Read the comment docs.

@nickvergessen nickvergessen merged commit 72b42af into master Apr 26, 2017
@nickvergessen nickvergessen deleted the contacts-menu-integration branch April 26, 2017 11:32
* @return TemplateResponse
* @throws HintException
* @throws HintException|RedirectResponse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it returns the response 😉

@Ivansss
Copy link
Member Author

Ivansss commented Apr 26, 2017

Tooltips are only visible for the first action (the most to the left).

No videocall tooltip visible here. Only visible the email tooltip.
screen shot 2017-04-26 at 14 34 05

Videocall tooltip is visible here because there is only one action.
screen shot 2017-04-26 at 14 33 13

@ChristophWurst

@ChristophWurst
Copy link
Member

@Ivansss now I see the problem. We have to add the tooltip to the second action too. Please create a ticket in the server repo and assign me. I'll take a look next week. Thanks :)

@jancborchardt
Copy link
Member

@Ivansss the tooltip is fixed to correct capitalized »Video call« now, right? ;)

@Ivansss
Copy link
Member Author

Ivansss commented Apr 28, 2017

@jancborchardt yes :) it was changed here #303

marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Darken modal mask background for better focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants