-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contacts menu integration #300
Conversation
Ivansss
commented
Apr 26, 2017
•
edited
Loading
edited
- Start a call with the user (internal users only) selected in contacts menu.
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Works here, good to merge? |
Works fine here as well 👍 |
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
============================================
- Coverage 15.72% 15.46% -0.26%
- Complexity 269 274 +5
============================================
Files 17 18 +1
Lines 1272 1293 +21
============================================
Hits 200 200
- Misses 1072 1093 +21
Continue to review full report at Codecov.
|
* @return TemplateResponse | ||
* @throws HintException | ||
* @throws HintException|RedirectResponse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it returns the response 😉
@Ivansss now I see the problem. We have to add the tooltip to the second action too. Please create a ticket in the server repo and assign me. I'll take a look next week. Thanks :) |
@Ivansss the tooltip is fixed to correct capitalized »Video call« now, right? ;) |
@jancborchardt yes :) it was changed here #303 |
Darken modal mask background for better focus