Breakout Rooms round 1 #8403
Merged
Breakout Rooms round 1 #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
6 times, most recently
from
05ce820 to
1bf4dc1
Compare
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
3 times, most recently
from
71f1aae to
1dac92d
Compare
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
from
1dac92d to
b5566af
Compare
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
4 times, most recently
from
b561143 to
0c7b548
Compare
| <label for="room-number">{{ t('spreed', 'Number of breakout rooms') }} </label> | ||
| <input id="room-number" v-model.number="amount" type="number"> | ||
| <NcCheckboxRadioSwitch :checked.sync="mode" | ||
| value="1" |
There was a problem hiding this comment.
Followup:
Suggested change
| value="1" | |
| :value="CONVERSATION.BREAKOUT_ROOM_MODE.AUTOMATIC" |
Same for others?
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
from
0c7b548 to
c557b48
Compare
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
from
c557b48 to
930dd1c
Compare
nickvergessen
requested changes
Jan 24, 2023
|
|
||
| async stopBreakoutRoomsAction(context, token) { | ||
| try { | ||
| await stopBreakoutRooms(token) |
There was a problem hiding this comment.
Followup:
Should change the conversation detail in the conversationStore when successful
|
|
||
| async startBreakoutRoomsAction(context, token) { | ||
| try { | ||
| await startBreakoutRooms(token) |
There was a problem hiding this comment.
Followup:
Should change the conversation detail in the conversationStore when successful
|
|
||
| async getBreakoutRoomsAction(context, { token }) { | ||
| try { | ||
| const response = await getBreakoutRooms(token) |
There was a problem hiding this comment.
Followup:
Don't get them when the conversation breakout room mode says they are off.
|
|
||
| async deleteBreakoutRoomsAction(context, { token }) { | ||
| try { | ||
| await deleteBreakoutRooms(token) |
There was a problem hiding this comment.
Followup:
Should change the conversation detail in the conversationStore when successful
| <input id="participant.attendeeId" | ||
| v-model="modelProxy" | ||
| :value="participant.attendeeId" | ||
| type="checkbox" |
There was a problem hiding this comment.
Followup:
Not accessible, we have a NcCheckbox… component
src/components/BreakoutRoomsEditor/BreakoutRoomsParticipantsEditor.vue
Outdated
Show resolved
Hide resolved
| <!-- TODO: choose final icon --> | ||
| <GoogleCircles :size="20" /> | ||
| </template> | ||
| {{ roomName(index) }} |
There was a problem hiding this comment.
Followup:
When there is only 1 room this behaves weird.
|
|
||
| data() { | ||
| return { | ||
| mode: '1', |
| <template v-if="!isEditingParticipants"> | ||
| <div class="breakout-rooms-editor__main"> | ||
| <label for="room-number">{{ t('spreed', 'Number of breakout rooms') }} </label> | ||
| <input id="room-number" v-model.number="amount" type="number"> |
There was a problem hiding this comment.
Followup:
If only NcInputField would allow numbers
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
marcoambrosini
force-pushed
the
feature/8339/breakout-rooms-round-1
branch
from
a345066 to
363ad43
Compare
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Marco <marcoambrosini@icloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
20 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco marcoambrosini@icloud.com
partially fixes #8339
🖼️ Screenshots