Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): Add Nextcloud 29 support on master #207

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2024

static-psalm-analysis-summary is expected but not part of the CI anymore.

Workflows should be updated from nextcloud/.github and CI requirement adapted. I can do it but I’d need admin rights, @nickvergessen Do you have those?

@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2024

(Looking into this because this application is shipped and it breaks nextcloud/updater CI that a shipped application does not support current master.)

@nickvergessen
Copy link
Member Author

static-psalm-analysis-summary is expected but not part of the CI anymore.

Looking at https://github.com/nextcloud/survey_client/blob/master/.github/workflows/psalm.yml I guess it is quite old and updating it would add the missing check ^^

But I can remove it for now

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2024

static-psalm-analysis-summary is expected but not part of the CI anymore.

Looking at master/.github/workflows/psalm.yml I guess it is quite old and updating it would add the missing check ^^

But I can remove it for now

I pushed an update of the workflow but I think there is no summary in this one so requirement will need to be adapted anyway.

@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2024

PHP module GD not installed.
Please ask your server administrator to install the module.

I’ll update phpunit workflows as well 🤷

@nickvergessen
Copy link
Member Author

updated static away from summary

@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2024

 Neither PHPUnit nor PHPUnit integration tests are specified in composer.json scripts
Error: Process completed with exit code 1.

Modern workflows are too smart 😆

Deleting the workflow as there are no unit tests.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit befbd70 into master Jan 23, 2024
10 checks passed
@come-nc come-nc deleted the update-master-version branch January 23, 2024 10:58
@nickvergessen
Copy link
Member Author

Deleting the workflow as there are no unit tests.

Recommended step is to run it with echo
Because then at least the migrations got run and you can be sure the app can still be enabled:
https://github.com/nextcloud/nextcloud_announcements/blob/master/composer.json#L26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants