-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency chart.js to v4 (master) - autoclosed #787
Conversation
d122fc4
to
3173fa4
Compare
43b9435
to
24014ae
Compare
24014ae
to
255a7da
Compare
255a7da
to
8d4cf93
Compare
8d4cf93
to
43e6643
Compare
43e6643
to
bd6996a
Compare
bd6996a
to
59c21fb
Compare
/compile |
@ChristophWurst Tests are passing but given this is a 2 major bump, it should be tested and the migrations guides looked at. I was not able to test it as the application needs 60days activation before showing a chart. |
105385b
to
78286a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING in ./node_modules/vue-chartjs/es/BaseCharts.js 62:32-37
export 'default' (imported as 'Chart') was not found in 'chart.js' (possible exports: Animation, Animations, ArcElement, BarController, BarElement, BasePlatform, BasicPlatform, BubbleController, CategoryScale, Chart, Colors, DatasetController, Decimation, DomPlatform, DoughnutController, Element, Filler, Interaction, Legend, LineController, LineElement, LinearScale, LogarithmicScale, PieController, PointElement, PolarAreaController, RadarController, RadialLinearScale, Scale, ScatterController, SubTitle, Ticks, TimeScale, TimeSeriesScale, Title, Tooltip, _adapters, _detectPlatform, animator, controllers, defaults, elements, layouts, plugins, registerables, registry, scales)
However, when also bumping vue-chartjs locally it builds but the UI completely breaks in a prod build. The breakage seems to be related to webpack being a bit too aggressive when tree-shaking.
See chartjs/Chart.js#10895 (comment) for a potential fix that is a bit hacky.
Uncaught ReferenceError: LinearScaleBase is not defined
<anonymous> chart.js:10227
<anonymous> main-settings.js:19
IMO the graph is mostly interesting for developers, not admins. I vote for just removing it to make the app easier to maintain. |
78286a9
to
aa3342c
Compare
This PR contains the following updates:
^2.9.4
->^4.4.4
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
chartjs/Chart.js (chart.js)
v4.4.4
Compare Source
Essential Links
Bugs Fixed
Types
Documentation
Development
Thanks to @CatchABus, @LeeLenaleee, @MichelHMachado, @artus9033, @huqingkun, @jdufresne and @joliss
v4.4.3
Compare Source
Essential Links
Bugs Fixed
Documentation
Development
Thanks to @DAcodedBEAT, @EricWittrock, @LeeLenaleee, @LiamSwayne, @dependabot and @dependabot[bot]
v4.4.2
Compare Source
Essential Links
Bugs Fixed
Types
Documentation
Development
Thanks to @DAcodedBEAT, @LeeLenaleee, @Megaemce, @dependabot, @dependabot[bot], @mirumirumi, @smoonsf and @waszkiewiczja
v4.4.1
Compare Source
Essential Links
Bugs Fixed
Types
Documentation
Development
Thanks to @CatchABus, @Cazka, @Connormiha, @LeeLenaleee, @Sengulair, @bboy-chocomint, @dependabot, @dependabot[bot], @jongwooo, @joshkel and @unverbraucht
v4.4.0
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @LeeLenaleee, @Mer-cat, @bogdankorshunov and @stockiNail
v4.3.3
Compare Source
Essential Links
Development
Thanks to @dependabot, @dependabot[bot] and @stockiNail
v4.3.2
Compare Source
Essential Links
Types
Development
Thanks to @LeeLenaleee, @joshkel and @stockiNail
v4.3.1
Compare Source
Essential Links
Bugs Fixed
Types
Documentation
Development
Thanks to @Frenzie, @LeeLenaleee, @etimberg, @matthewhegarty, @mukham12, @skopz356 and @stockiNail
v4.3.0
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @CodingMarco, @Connormiha, @Demir-Utku, @LeeLenaleee, @dangreen, @defunctzombie, @etimberg, @leo2436, @olenderhub, @shahabhm, @stockiNail and @timgates42
v4.2.1
Compare Source
Essential Links
Bugs Fixed
Types
Documentation
Development
Thanks to @LeeLenaleee, @choichoijin, @dangreen, @etimberg, @jljouannic, @johakr, @n1313 and @stockiNail
v4.2.0
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @ankane, @igorlukanin, @mlankamp and @stockiNail
v4.1.2
Compare Source
Essential Links
Types
Documentation
Development
Thanks to @LeeLenaleee, @dangreen and @matveycodes
v4.1.1
Compare Source
Essential Links
Bugs Fixed
Types
Development
Thanks to @dangreen, @etimberg, @gbaron and @igorlukanin
v4.1.0
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @Kit-p, @LeeLenaleee, @Simon-He95, @benmccann, @dangreen, @etimberg, @igorlukanin, @letheri and @stockiNail
v4.0.1
Compare Source
Essential Links
Bugs Fixed
Thanks to @LeeLenaleee
v3.9.1
Compare Source
Essential Links
Bugs Fixed
Thanks to @LeeLenaleee
v3.9.0
Compare Source
Essential Links
Enhancements
Performance
Bugs Fixed
Documentation
Development
Thanks to @LeeLenaleee, @M4sterShake, @benmccann, @dangreen, @kurkle, @peterhauke, @stockiNail, @thabarbados and @touletan
v3.8.2
Compare Source
Essential Links
Bugs Fixed
Development
Thanks to @etimberg
v3.8.1
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @LeeLenaleee, @Pourbahrami, @andrewl64, @dependabot, @dependabot[bot], @etimberg, @ideabrian, @igorlukanin, @kurkle, @naveensrinivasan, @stockiNail and @touletan
v3.8.0
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @CommanderRoot, @LeeLenaleee, @Talla2XLC, @akiraaso, @dependabot, @dependabot[bot], @etimberg, @joshkel, @kurkle, @kylejonesdev, @linkviii, @luke-heberling, @msteiger, @pzelnip, @t-mangoe and @yhvicey
v3.7.1
Compare Source
Essential Links
Bugs Fixed
Types
Documentation
Development
Thanks to @DimitriPapadopoulos, @LeeLenaleee, @LovelyAndy, @caub, @charlesmass2, @etimberg, @jmorel and @stockiNail
v3.7.0
Compare Source
Essential Links
Enhancements
Bugs Fixed
Types
Documentation
Development
Thanks to @LeeLenaleee, @doug-a-brunner, @joshkel, @kurkle, @luukdv and @t-mangoe
v3.6.2
Compare Source
Essential Links
Bugs Fixed
Development
Thanks to @kurkle
v3.6.1
Compare Source
Essential Links
Bugs Fixed
Types
Configuration
📅 Schedule: Branch creation - "before 5am on thursday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.