Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suspicious_login): Add "more info" button to email notifications #873

Merged
merged 2 commits into from
May 12, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Apr 27, 2024

Fixes #801

Relies on existing app config parameter already used for toggling in-app notifications.

Fixes #801

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added enhancement New feature or request 3. to review labels Apr 27, 2024
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone Apr 27, 2024
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

Tested. Works. :)

@joshtrichards joshtrichards requested a review from szaimen May 6, 2024 19:56
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. I did not test.

lib/Listener/LoginMailListener.php Show resolved Hide resolved
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thank you very much!

@st3iny st3iny merged commit 93aed8c into master May 12, 2024
31 checks passed
@st3iny st3iny deleted the feat/email-info-button branch May 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button to email notifications to get more info about the suspicious ip
2 participants