Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LoginClassifier): Adjust log levels / reduce logging noise #875

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

joshtrichards
Copy link
Member

While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered.

  • Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited
  • Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels

This cuts down on the log noise from "Detected a login from a suspicious login..."

All logs remain available at the appropriate log levels if desired.

Fixes #303

@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 3, 2024
@joshtrichards joshtrichards added 3. to review bug Something isn't working labels May 3, 2024
@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards
Copy link
Member Author

/backport to stable27

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks more like fighting the symptoms rather than fixing the actual issue.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered.

* Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited
* Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels

This cuts down on the log noise from "Detected a login from a suspicious login..." 

All logs remain available at the appropriate log levels if desired.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@st3iny st3iny merged commit b69f788 into master Sep 30, 2024
28 checks passed
@st3iny st3iny deleted the fix-logging-noise-reduction branch September 30, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Everything is flagged as suspicious
4 participants